fix(helm): add missing keys for securityContexts #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanehi
force-pushed
the
fix/add-securityContext-containerlevel
branch
from
fe85e8a
to
85c8152
Compare
|
@yanehi Image is available for testing. |
yanehi
force-pushed
the
fix/add-securityContext-containerlevel
branch
from
85c8152
to
999516e
Compare
|
hi @yanehi , thanks for the PR, i will test this soon and will try to resolve why tests are failing. |
MuneebAijaz
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the values you can set the securityContext on container level, but the corresponding key is missing in the deployment.
The setting of the securityContext for the kube-rbac-proxy container has also been added.
Solution
Optionally, the securityCotext for the manager and kube-rbac-proxy container can be set.