Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tag in pull request gh action #600

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

dennis-ge
Copy link
Contributor

Hey @bnallapeta and @MuneebAijaz, I opened #599 but the pull request workflow is failing because of a small bug:

  • The Build and Push image to ghcr registry step is using ${{ env.GHCR_IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.new_tag }} as tag.
  • However, the generate_tag step is not outputting new_tag but GIT_TAG
  • Probably a copy paste error because the push workflow uses the anothrNick/github-tag-action@1.61.0 github action for generate_tag, which in turn outputs new_tag. The pull request workflow instead uses some shell commands to generate the tag
  • This was introduced in Update workflows to push images to ghcr #597.

Could you please have a look?

Once this is approved, I will update my other PR.

Copy link

@dennis-ge Yikes! You better fix it before anyone else finds out! Build has Failed!

@bnallapeta bnallapeta merged commit dc6ac05 into stakater:master Jun 25, 2024
1 check failed
@dennis-ge dennis-ge deleted the fix-gh-action branch June 25, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants