Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim spaces in annotation list #165

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

juliabiro
Copy link
Contributor

@juliabiro juliabiro commented Sep 22, 2020

Our users often provide their annotation list about secrets to watch in a comma AND space separated list, like this:
"secret1, secret2, secret3". This causes Reloader to pick up on only the first secret, and ignoring changes on the rest. Since this is a very natural expression of lists and aligns with the format used in other annotation lists, I would like to accommodate this.

I bumped into some problems in our systems because of the extra spaces, this is why I am posting this PR. I am happy to answer any questions.

@juliabiro juliabiro changed the title Only trim spaces Trim spaces in annotation list Sep 22, 2020
@stakater-user
Copy link
Contributor

@juliabiro Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-165-1

@stakater-user
Copy link
Contributor

@juliabiro Image is available for testing. docker pull stakater/reloader:SNAPSHOT-PR-165-2

@rasheedamir rasheedamir merged commit ed6ea02 into stakater:master Sep 22, 2020
@juliabiro juliabiro deleted the only_trim_spaces branch September 22, 2020 15:16
@blackjid
Copy link

This is very helpful because you can use the Replace newlines with spaces (folded) from yaml so you can list each secret on it's own line https://yaml-multiline.info/

secret.reloader.stakater.com/reload: >-
  first-secret,
  second-secret,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants