Auto update referenced resource #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
…g the resources Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
golangcibot
reviewed
Jan 21, 2019
|
@faizanahmad055 Image is available for testing. |
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
|
@faizanahmad055 Yikes! You better fix it before anyone else finds out! Build 2 has Failed! |
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
|
@waseem-h, @kahootali , can you guys please take a look at this PR. |
|
@faizanahmad055 Image is available for testing. |
kahootali
approved these changes
Jan 23, 2019
waseem-h
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does following
Fixed the issue where it reloads the pod even if configmap/secret is not being used in the pod (i.e. Not mounted or referenced via environment variable).
Added support for create event, now reloader performs rolling upgrade when a configmap/secret is created as well.
Added support to automatically discover the deplyments/daemonsets/statefulsets when their referenced configmap/secret is created/updated.
Now we just have to add this annotation in our deployment, daemonset or statefulset
Note: It is backward compatible and old annotations work as well. But if we use this new annotation with old annotations, this annotation will override the old annotations.