-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log-level): add option to set logLevel in chart #687
Conversation
@dabcoder Images are available for testing. |
Tested with:
Yet in the actual container logs I can see:
Feedback welcome. |
cc @MuneebAijaz |
hi @dabcoder thanks for the PR, if the actual flag doesn't work for log levels, we might need to fix that first. |
Yes that's what I was trying to check and figure out but I don't immediately see any issues with the flag in the codebase. I can take another look anyway. |
Hi, For me this is the only Log-Message that doesn't consider the options. |
@martin-gutwin thanks for the insights, didn't think about that. So I can update this PR to resolve the conflicts then. |
@dabcoder Images are available for testing. |
Can this PR be re-reviewed and merged if it satisfy requirements? |
hi @dabcoder we have to do some changes to chart workflows, till then this sadly cant be merged. I will merge this when workflows are fixed. |
Any updates on the above? Thanks. |
cc @MuneebAijaz |
Implements #681.