Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update wording in readme #730

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

deggja
Copy link
Contributor

@deggja deggja commented Aug 22, 2024

Updated the wording in the readme to avoid confusion, because if you read it in a certain way, you might misunderstand and think the configmap and/or secret requires a certain naming convention for reloader to work.

Solves confusion, like in #663

Signed-off-by: deggja <danieldagfinrud@gmail.com>
Signed-off-by: deggja <danieldagfinrud@gmail.com>
@karl-johan-grahn karl-johan-grahn merged commit 6b856c8 into stakater:master Aug 22, 2024
5 checks passed
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Aug 29, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [reloader](https://github.com/stakater/Reloader) | minor |
`1.0.121` -> `1.1.0` |

---

### Release Notes

<details>
<summary>stakater/Reloader (reloader)</summary>

###
[`v1.1.0`](https://github.com/stakater/Reloader/releases/tag/v1.1.0)

[Compare
Source](https://github.com/stakater/Reloader/compare/v1.0.121...v1.1.0)

#### Announcement 📢 📢 📢

Discussions are being done internally on `how to release helm charts`,
it is highly likely that the release **versioning of helm chart and
images will become divergent** from next release onwards.
(Different versioning for both artifacts, for example git release of
`v1.1.1` might not have a chart released with the same version)
Pls edit your automated workflows to accommodate for this change before
the new release to have seamless updates in your clusters.

#### What's Changed

- Manual release workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/722](https://github.com/stakater/Reloader/pull/722)
- fixing go vet issues with logrus by
[@&#8203;bnallapeta](https://github.com/bnallapeta) in
[https://github.com/stakater/Reloader/pull/727](https://github.com/stakater/Reloader/pull/727)
- Fixing Rollout restart, Previously would trigger rollout deployment
strategy by [@&#8203;jangeja](https://github.com/jangeja) in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- Misc fixes to workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/728](https://github.com/stakater/Reloader/pull/728)
- docs: update wording in readme by
[@&#8203;deggja](https://github.com/deggja) in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- chore(deps): update dependency stakater/vale-package to v0.0.33 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/stakater/Reloader/pull/721](https://github.com/stakater/Reloader/pull/721)
- Reduce footprint of UBI images by
[@&#8203;bainsy88](https://github.com/bainsy88) in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)
- Update dependencies by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/735](https://github.com/stakater/Reloader/pull/735)

#### New Contributors

- [@&#8203;jangeja](https://github.com/jangeja) made their
first contribution in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- [@&#8203;deggja](https://github.com/deggja) made their first
contribution in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- [@&#8203;bainsy88](https://github.com/bainsy88) made their
first contribution in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)

**Full Changelog**:
stakater/Reloader@v1.0.121...v1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4zIiwidXBkYXRlZEluVmVyIjoiMzguNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
lumiere-bot bot referenced this pull request in coolguy1771/home-ops Aug 29, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [reloader](https://github.com/stakater/Reloader) | minor |
`1.0.121` -> `1.1.0` |

---

### Release Notes

<details>
<summary>stakater/Reloader (reloader)</summary>

###
[`v1.1.0`](https://github.com/stakater/Reloader/releases/tag/v1.1.0)

[Compare
Source](https://github.com/stakater/Reloader/compare/v1.0.121...v1.1.0)

#### Announcement 📢 📢 📢

Discussions are being done internally on `how to release helm charts`,
it is highly likely that the release **versioning of helm chart and
images will become divergent** from next release onwards.
(Different versioning for both artifacts, for example git release of
`v1.1.1` might not have a chart released with the same version)
Pls edit your automated workflows to accommodate for this change before
the new release to have seamless updates in your clusters.

#### What's Changed

- Manual release workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/722](https://github.com/stakater/Reloader/pull/722)
- fixing go vet issues with logrus by
[@&#8203;bnallapeta](https://github.com/bnallapeta) in
[https://github.com/stakater/Reloader/pull/727](https://github.com/stakater/Reloader/pull/727)
- Fixing Rollout restart, Previously would trigger rollout deployment
strategy by [@&#8203;jangeja](https://github.com/jangeja) in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- Misc fixes to workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/728](https://github.com/stakater/Reloader/pull/728)
- docs: update wording in readme by
[@&#8203;deggja](https://github.com/deggja) in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- chore(deps): update dependency stakater/vale-package to v0.0.33 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/stakater/Reloader/pull/721](https://github.com/stakater/Reloader/pull/721)
- Reduce footprint of UBI images by
[@&#8203;bainsy88](https://github.com/bainsy88) in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)
- Update dependencies by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/735](https://github.com/stakater/Reloader/pull/735)

#### New Contributors

- [@&#8203;jangeja](https://github.com/jangeja) made their
first contribution in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- [@&#8203;deggja](https://github.com/deggja) made their first
contribution in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- [@&#8203;bainsy88](https://github.com/bainsy88) made their
first contribution in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)

**Full Changelog**:
stakater/Reloader@v1.0.121...v1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4zIiwidXBkYXRlZEluVmVyIjoiMzguNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
spiceratops referenced this pull request in spiceratops/k8s-gitops Aug 30, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [reloader](https://github.com/stakater/Reloader) | minor |
`1.0.121` -> `1.1.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>stakater/Reloader (reloader)</summary>

###
[`v1.1.0`](https://github.com/stakater/Reloader/releases/tag/v1.1.0)

[Compare
Source](https://github.com/stakater/Reloader/compare/v1.0.121...v1.1.0)

#### Announcement 📢 📢 📢

Discussions are being done internally on `how to release helm charts`,
it is highly likely that the release **versioning of helm chart and
images will become divergent** from next release onwards.
(Different versioning for both artifacts, for example git release of
`v1.1.1` might not have a chart released with the same version)
Pls edit your automated workflows to accommodate for this change before
the new release to have seamless updates in your clusters.

#### What's Changed

- Manual release workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/722](https://github.com/stakater/Reloader/pull/722)
- fixing go vet issues with logrus by
[@&#8203;bnallapeta](https://github.com/bnallapeta) in
[https://github.com/stakater/Reloader/pull/727](https://github.com/stakater/Reloader/pull/727)
- Fixing Rollout restart, Previously would trigger rollout deployment
strategy by [@&#8203;jangeja](https://github.com/jangeja) in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- Misc fixes to workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/728](https://github.com/stakater/Reloader/pull/728)
- docs: update wording in readme by
[@&#8203;deggja](https://github.com/deggja) in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- chore(deps): update dependency stakater/vale-package to v0.0.33 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/stakater/Reloader/pull/721](https://github.com/stakater/Reloader/pull/721)
- Reduce footprint of UBI images by
[@&#8203;bainsy88](https://github.com/bainsy88) in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)
- Update dependencies by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/735](https://github.com/stakater/Reloader/pull/735)

#### New Contributors

- [@&#8203;jangeja](https://github.com/jangeja) made their
first contribution in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- [@&#8203;deggja](https://github.com/deggja) made their first
contribution in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- [@&#8203;bainsy88](https://github.com/bainsy88) made their
first contribution in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)

**Full Changelog**:
stakater/Reloader@v1.0.121...v1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4zIiwidXBkYXRlZEluVmVyIjoiMzguNTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=-->
renovate bot referenced this pull request in anza-labs/manifests Sep 11, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [reloader](https://github.com/stakater/Reloader) | minor |
`1.0.121` -> `1.1.0` |

---

### Release Notes

<details>
<summary>stakater/Reloader (reloader)</summary>

###
[`v1.1.0`](https://github.com/stakater/Reloader/releases/tag/v1.1.0)

[Compare
Source](https://github.com/stakater/Reloader/compare/v1.0.121...v1.1.0)

##### Announcement 📢 📢 📢

Discussions are being done internally on `how to release helm charts`,
it is highly likely that the release **versioning of helm chart and
images will become divergent** from next release onwards.
(Different versioning for both artifacts, for example git release of
`v1.1.1` might not have a chart released with the same version)
Pls edit your automated workflows to accommodate for this change before
the new release to have seamless updates in your clusters.

##### What's Changed

- Manual release workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/722](https://github.com/stakater/Reloader/pull/722)
- fixing go vet issues with logrus by
[@&#8203;bnallapeta](https://github.com/bnallapeta) in
[https://github.com/stakater/Reloader/pull/727](https://github.com/stakater/Reloader/pull/727)
- Fixing Rollout restart, Previously would trigger rollout deployment
strategy by [@&#8203;jangeja](https://github.com/jangeja) in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- Misc fixes to workflows by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/728](https://github.com/stakater/Reloader/pull/728)
- docs: update wording in readme by
[@&#8203;deggja](https://github.com/deggja) in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- chore(deps): update dependency stakater/vale-package to v0.0.33 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/stakater/Reloader/pull/721](https://github.com/stakater/Reloader/pull/721)
- Reduce footprint of UBI images by
[@&#8203;bainsy88](https://github.com/bainsy88) in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)
- Update dependencies by
[@&#8203;MuneebAijaz](https://github.com/MuneebAijaz) in
[https://github.com/stakater/Reloader/pull/735](https://github.com/stakater/Reloader/pull/735)

##### New Contributors

- [@&#8203;jangeja](https://github.com/jangeja) made their
first contribution in
[https://github.com/stakater/Reloader/pull/724](https://github.com/stakater/Reloader/pull/724)
- [@&#8203;deggja](https://github.com/deggja) made their first
contribution in
[https://github.com/stakater/Reloader/pull/730](https://github.com/stakater/Reloader/pull/730)
- [@&#8203;bainsy88](https://github.com/bainsy88) made their
first contribution in
[https://github.com/stakater/Reloader/pull/717](https://github.com/stakater/Reloader/pull/717)

**Full Changelog**:
stakater/Reloader@v1.0.121...v1.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/anza-labs/manifests).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants