Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure GOMAXPROCS and GOMEMLIMIT has a divisor set #742

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Sep 8, 2024

Currently argocd complains that divisor is different between manifest and live.

I don't fully understand the field, but it looks like it sets how the resource field should be interpreted.

Same fix as traefik/traefik-helm-chart#1065 which seems to be the same problem.

@perpective2410
Copy link

perpective2410 commented Sep 9, 2024

Thank you for reporting, same issue here
Reloader 1.0.121, AKS 1.30.3, ArgoCD 2.12.3

image

@bnallapeta
Copy link

bnallapeta commented Sep 9, 2024

Looks like it does default to 0 when nothing is specified.

@halkeye The file in which you have made a change is a generated file by our pipelines and would be updated. Could you make the same change in here: https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/deployment.yaml

@halkeye
Copy link
Contributor Author

halkeye commented Sep 9, 2024

added

@pcharlan
Copy link

Seeing the same problem here. According to this k8s docs page on the downward API:

The divisor field is optional and has the default value of 1. A divisor of 1 means cores for cpu resources, or bytes for memory resources.

but in our k8s v1.28.12 deployments the divisor is being set to "0", confusing ArgoCD as described in this ticket.

Thanks to the devs for Reloader, and thanks @halkeye for the bug report!

@bnallapeta bnallapeta merged commit 9a7c9cb into stakater:master Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants