Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the global image tages #783

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Fix the global image tages #783

merged 7 commits into from
Nov 22, 2024

Conversation

bjorns163
Copy link
Contributor

When testings the helm chart on OpenShift 4.14 (Kubernetes version: v1.27.16)
I noticed that these tags global.imageRegistry and global.imagePullSecrets were not correctly working, here the fix

use imagePullSecrets from gloabl
Make sure values being seen. With $ the values file doesn't find the value.
Add example of usage   imagePullSecrets
@MuneebAijaz
Copy link
Contributor

hi @bjorns163 can u pls rebase on master branch, and update helm chart version prematurely in chart.yaml?

@MuneebAijaz
Copy link
Contributor

You'd need to update the version here to 1.2.1 we update it before releasing now so git state is synced with chart in artifact repo
https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml#L6

1 similar comment
@MuneebAijaz
Copy link
Contributor

You'd need to update the version here to 1.2.1 we update it before releasing now so git state is synced with chart in artifact repo
https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml#L6

@bjorns163
Copy link
Contributor Author

Ok I've updated the version and synced project

@MuneebAijaz
Copy link
Contributor

appVersion will stay the same because theres no image available for 1.2.1 yet. we plan to separate out versioning for these two things. so in ur case, chart version will be ahead of image version, which is completely fine. appVersion points to application version, which will stay the same

@bjorns163
Copy link
Contributor Author

Ok i set the appversion back.

@MuneebAijaz MuneebAijaz merged commit 145679a into stakater:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants