-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the global image tages #783
Conversation
use imagePullSecrets from gloabl
Make sure values being seen. With $ the values file doesn't find the value.
Add example of usage imagePullSecrets
hi @bjorns163 can u pls rebase on master branch, and update helm chart version prematurely in chart.yaml? |
You'd need to update the version here to |
1 similar comment
You'd need to update the version here to |
Ok I've updated the version and synced project |
appVersion will stay the same because theres no image available for 1.2.1 yet. we plan to separate out versioning for these two things. so in ur case, chart version will be ahead of image version, which is completely fine. appVersion points to application version, which will stay the same |
Ok i set the appversion back. |
When testings the helm chart on OpenShift 4.14 (Kubernetes version: v1.27.16)
I noticed that these tags global.imageRegistry and global.imagePullSecrets were not correctly working, here the fix