[STK-322] Update readme to resolve any confusions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@faizanahmad055 Yikes! You better fix it before anyone else finds out! Build 1 has Failed! |
hazim1093
requested changes
Jul 27, 2018
| @@ -33,8 +33,14 @@ metadata: | |||
| Then, providing `Reloader` is running, whenever you edit the `ConfigMap` or `Secret` called `foo` the Reloader will update the `Deployment` by adding the environment variable: | |||
There was a problem hiding this comment.
Add this section in a new heading of How Reloader works
|
@faizanahmad055 Image is available for testing. |
|
@faizanahmad055 Image is available for testing. |
rasheedamir
requested changes
Jul 29, 2018
| watchGlobally: true |
There was a problem hiding this comment.
@faizanahmad055 plz ensure that in vanilla manifest its globally true as well
There was a problem hiding this comment.
Updated, please review
|
@faizanahmad055 Image is available for testing. |
|
@faizanahmad055 Image is available for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.