Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color of all error toasts from connectManagerErrorState #83

Open
1 task
tomastiminskas opened this issue Feb 3, 2025 · 1 comment
Open
1 task
Assignees
Labels

Comments

@tomastiminskas
Copy link
Contributor

Show error toast with red background color instead of green

Base branch: develop: All new changes needs to be done using develop branch as base branch. We use develop as base for Test Flight distribution releases

Context

All errors collected by connectManagerErrorState are currently shown with green background. We want to change that to a red background to be more descriptive as an error instead of a notification

Screenshot

Image

Requirements

  • Create new NotifyError class method in ChatListSideEffect, ChatSideEffect and OnBoardConnectingSideEffect to implement toast with R.color.badgeRed background color. SphinxToastUtils has a optional param for toastBackgroundTint to be passed in the new method
  • Replace Notify by NotifyError on all submitSideEffect calls when collecting connectManagerRepository.connectManagerErrorState in DashboardViewModel, ChatViewModel and OnboardConnectingViewModel

Acceptance Criteria

  • Show all connect manager error messages with red background instead of green
@turizspace
Copy link

Assign me, i can assist with this task.

turizspace added a commit to turizspace/sphinx-android-v2 that referenced this issue Feb 5, 2025
Showing all connect manager error messages with red background instead of green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants