Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Generate Tests" with "Analyze Test Coverage" in Repository Node #2510

Conversation

MahtabBukhari
Copy link
Contributor

Ticket №: #2501

closes #2501

Problem:

insert problem you are trying to solve here

Evidence:

For testing I have used Tweet node_type in real their is repository node_type

https://www.loom.com/share/5135cad7419c4ec8a2b6b8b6e57e67e4?sid=7abb5074-ded2-4a2f-b90d-5923f3c33d3b

@MahtabBukhari
Copy link
Contributor Author

MahtabBukhari commented Dec 6, 2024

@tomsmith8 @Rassl Could you please review this PR ?

Cypress tests are also be failing on testing PR #2511 that has no any changes so these cypress tests are not failing by this PR only

image

@MahtabBukhari
Copy link
Contributor Author

@Rassl Could you please review this PR?

@MahtabBukhari
Copy link
Contributor Author

@Rassl please review this PR 🙏🏻

@Rassl
Copy link
Collaborator

Rassl commented Feb 5, 2025

@MahtabBukhari we need to change couple things:

  • when user clicks analyze, we should clear dataStore, by calling resetData from useDataStore similar to src/components/App/UniverseQuestion/index.tsx
  • when we get new nodes from provided endpoint, we should call addNewNode from useDataStore with new nodes, and links(empty)

@MahtabBukhari
Copy link
Contributor Author

  • calling resetData

@Rassl updated please review it now

@Rassl
Copy link
Collaborator

Rassl commented Feb 6, 2025

  • calling resetData

@Rassl updated please review it now

Hey @MahtabBukhari, please fix lint, build errors. Skip failing tests.

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look to my comments

@MahtabBukhari
Copy link
Contributor Author

Please take a look to my comments

@Rassl Could you please review it now?

@tomsmith8
Copy link
Contributor

@Rassl can you prioritise this

@Rassl Rassl merged commit 4d5c6d0 into stakwork:master Feb 10, 2025
12 of 17 checks passed
@tomsmith8
Copy link
Contributor

@MahtabBukhari hey! could we update the endpoint name and call convention sorry:

/api/git/analyze?git_repository=stakwork/sphinx-tribes&analysis=["coverage"]

  • /api/github/analzye to /api/git/analyze
  • github_repository to git_repository

@tomsmith8
Copy link
Contributor

Screenshot 2025-02-13 at 11 32 26

Could we also remove these 3 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "Generate Tests" with "Analyze Test Coverage" in Repository Node
3 participants