perf(get): replaces reduce with for loop in hot function

stalniy · Oct 17, 2020 · e54d86a · e54d86a
1 parent 0dc832a
commit e54d86a
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/packages/js/src/utils.ts b/packages/js/src/utils.ts
@@ -23,14 +23,20 @@ export function isArrayAndNotNumericField<T>(object: T | T[], field: string): ob
 }
 
 function getField<T extends AnyObject>(object: T | T[], field: string, get: GetField) {
-  if (isArrayAndNotNumericField(object, field)) {
-    return object.reduce((acc, item) => {
-      const value = get(item, field);
-      return value !== undefined ? acc.concat(value) : acc;
-    }, []);
+  if (!isArrayAndNotNumericField(object, field)) {
+    return get(object, field);
   }
 
-  return get(object, field);
+  let result: unknown[] = [];
+
+  for (let i = 0; i < object.length; i++) {
+    const value = get(object[i], field);
+    if (typeof value !== 'undefined') {
+      result = result.concat(value);
+    }
+  }
+
+  return result;
 }
 
 export function getValueByPath(object: AnyObject, field: string, get: GetField) {