fix(sql): Interpreters should add one join per relation at most #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix but I think it was fixed in alpha branch, I used |
If a condition specifies the same relation several times the interpreters should add the join statement only once.
|
anyway, thanks for the contribution! I adjusted it for alpha version and going to release a new version now |
|
released in @ucast/sql@1.0.0-alpha.12 |
|
Thanks for merging this! 😃 Next time I will start the PR from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a condition specifies the same relation several times the interpreters should add the join statement only once.
Before this patch:
typeormadd a join statement for each condition that refers to the same relation.sequelizedoesn't include any relation becausejoinsvar was emptied duringmergeoperation.