debug, map, flatten bug #91
Labels
Comments
|
I have a stream that does not emit anything unless there is a .debug(noop) tacked on the end. Do you think it is related, or should I post another issue with detail? |
|
Just open another issue. We can't be sure yet it is the same bug. |
staltz
added a commit
that referenced
this issue
Aug 16, 2016
To fix bugs such as #91 and others where adding .debug() would magically solve the bug, we need to change the semantics around producer stop and stream completion/error. Previously, a stream would complete first, and stop the producer after. Now, the stream stops its producer just before completing. This was important to make the test 'Stream.prototype.flatten with map should not run multiple executions of the inner' pass. BREAKING CHANGE: in this version, when a stream completes or errors, its producer has already been stopped. In previous versions, the stream first completes, propagates the complete to other listeners and operators, and then its producer is stopped. You may barely notice this breaking change when updating your code. Most existing code will still work like before.
staltz
added a commit
that referenced
this issue
Aug 20, 2016
To fix bugs such as #91 and others where adding .debug() would magically solve the bug, we need to change the semantics around producer stop and stream completion/error. Previously, a stream would complete first, and stop the producer after. Now, the stream stops its producer just before completing. This was important to make the test 'Stream.prototype.flatten with map should not run multiple executions of the inner' pass. BREAKING CHANGE: in this version, when a stream completes or errors, its producer has already been stopped. In previous versions, the stream first completes, propagates the complete to other listeners and operators, and then its producer is stopped. You may barely notice this breaking change when updating your code. Most existing code will still work like before.
|
This should be fixed now in v6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http://jsbin.com/hihuvuqupo/edit?html,js,console
The text was updated successfully, but these errors were encountered: