-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull correct linux arch for stanc3 #1033
Pull correct linux arch for stanc3 #1033
Conversation
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Will take a look a bit later. What do you think would be the best way of providing the tarballs at release time? A separate tarball for each arch? I guess a single tarball would be huge. And the names of the tarballs would be the same as the ARCH_TAG you use here? That would mean cmdstan-2.28.0-linux-mips64el.tar.gz Does that work for you? |
Yeah a separate tarball for each with the ARCH_TAG would be best (if that's not too many tarballs!). Is that build process somewhere? I can make those changes as well, if it's easier |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
@serban-nicusor-toptal does the tarball packaging and can tell you more about that, but I guess that is just a bash script that lives in some other repository? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
For the cmdstan tarball I have a 3 line script locally that just archives it (after release) and removes the weird files mac adds. |
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
This PR adds the functionality for downloading the stanc3 for additional architectures on linux. The following architectures are now supported:
arm64
armel
armhf
mips64el
ppc64el
s390x
I've tested this under QEMU, and the correct stanc3 binary is downloaded and the bernoulli model compiles and runs under all architectures
Intended Effect:
Automatic support for
cmdstan
across more linux architecturesHow to Verify:
Call
make build
on a non-x86 linux systemSide Effects:
N/A
Documentation:
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: