-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1192 save metric json #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
reviewed
Sep 25, 2023
…an-dev/cmdstan into feature/1192-save-metric-json
…an-dev/cmdstan into feature/1192-save-metric-json
…an-dev/cmdstan into feature/1192-save-metric-json
this is ready for re-review |
WardBrian
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really nice. A few comments but they're all minor now
one mo' time? |
WardBrian
approved these changes
Oct 25, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Add option to adaptive sampler args to save metric in separate JSON file with elements "stepsize" and "inv_metric"
Intended Effect:
Easy way to get pre-specified metric.
How to Verify:
Unit tests will pass once stan-dev/stan#3230 has been merged.
Side Effects:
N/A
Documentation:
Will add separately to docs repo.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: