Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1192 save metric json #1203

Merged
merged 20 commits into from
Oct 25, 2023
Merged

Conversation

mitzimorris
Copy link
Member

@mitzimorris mitzimorris commented Sep 18, 2023

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Add option to adaptive sampler args to save metric in separate JSON file with elements "stepsize" and "inv_metric"

Intended Effect:

Easy way to get pre-specified metric.

How to Verify:

Unit tests will pass once stan-dev/stan#3230 has been merged.

Side Effects:

N/A

Documentation:

Will add separately to docs repo.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris
Copy link
Member Author

this is ready for re-review

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice. A few comments but they're all minor now

src/cmdstan/command.hpp Show resolved Hide resolved
src/cmdstan/command_helper.hpp Outdated Show resolved Hide resolved
src/test/interface/command_test.cpp Outdated Show resolved Hide resolved
src/test/interface/save_metric_json_test.cpp Outdated Show resolved Hide resolved
src/test/interface/save_metric_json_test.cpp Outdated Show resolved Hide resolved
src/test/interface/save_metric_json_test.cpp Outdated Show resolved Hide resolved
src/cmdstan/command.hpp Outdated Show resolved Hide resolved
@mitzimorris
Copy link
Member Author

one mo' time?

@mitzimorris mitzimorris merged commit e9fb1a9 into develop Oct 25, 2023
1 check passed
@WardBrian WardBrian deleted the feature/1192-save-metric-json branch October 25, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants