Makefile: TBB is a dependency of bin helpers #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syclik
reviewed
Oct 3, 2023
| @@ -2,13 +2,13 @@ ifeq ($(CMDSTAN_SUBMODULES),1) | |||
| bin/cmdstan/stansummary.o : src/cmdstan/stansummary_helper.hpp | |||
| bin/cmdstan/%.o : src/cmdstan/%.cpp | |||
| @mkdir -p $(dir $@) | |||
| $(COMPILE.cpp) -fvisibility=hidden $(OUTPUT_OPTION) $(LDLIBS) $< | |||
| $(COMPILE.cpp) -fvisibility=hidden $< $(OUTPUT_OPTION) | |||
There was a problem hiding this comment.
Was this change intended? I think it's a good change: the use of libs shouldn't be necessary when compiling, only linking.
There was a problem hiding this comment.
Yes, it currently generates warnings for unused arguments, so I removed it
syclik
approved these changes
Oct 3, 2023
|
Awesome. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Currently, running
make bin/stansummarywithout first runningmake buildfails, because these link TBB but do not have it marked as a dependency.This can, rarely, cause
make buildto fail, like in CI here: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStan/detail/downstream_tests/366/pipelineIntended Effect:
Fix
make bin/stansummaryHow to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: