Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly re-build main.o when threading, etc enabled #1219

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

The automatically generated .d files were not previously working for our main object file when a flag like STAN_THREADS=true was set.

We're doing very nearly the same thing with the precompiled header already

Intended Effect:

Closes #998

How to Verify:

  • build bernoulli with STAN_THREADS
  • edit a file in cmdstan's source directory
  • re-run the same make command as step 1, see that a rebuild is triggered

Side Effects:

None

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian merged commit 56a8779 into develop Nov 8, 2023
1 check passed
@WardBrian WardBrian deleted the fix/998-main-o-dependencies branch November 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make doesn't manage dependencies of Stan library correctly when STAN_THREADS=true
2 participants