Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement calculate_lp, diagnostic args for laplace #1246

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Exposes new arguments for laplace from stan-dev/stan#3261.

calculate_lp is a boolean subarg of laplace which controls whether or not log_prob is called for each approximate draw. Default is true (existing behavior).

For the hessian and other information, I re-used the diagnostic_file argument of output. This matches with e.g. the JSON outputs of Pathfinder, but if we want a dedicated argument I can add one.

Intended Effect:

Expose new arguments to the laplace sample algorithm

How to Verify:

These are tested in the Stan implementation. I can add more here if desired.

Side Effects:

Documentation:

TBD

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian
Copy link
Member Author

Just to check: @avehtari - does this sound like it does everything you wanted?

@avehtari
Copy link
Contributor

Sounds good

@WardBrian WardBrian merged commit 67fbbe6 into develop Jan 31, 2024
1 check passed
@WardBrian WardBrian deleted the feature/laplace-control-args branch January 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants