Implement calculate_lp, diagnostic args for laplace #1246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Exposes new arguments for
laplace
from stan-dev/stan#3261.calculate_lp
is a boolean subarg oflaplace
which controls whether or not log_prob is called for each approximate draw. Default is true (existing behavior).For the hessian and other information, I re-used the
diagnostic_file
argument of output. This matches with e.g. the JSON outputs of Pathfinder, but if we want a dedicated argument I can add one.Intended Effect:
Expose new arguments to the
laplace
sample algorithmHow to Verify:
These are tested in the Stan implementation. I can add more here if desired.
Side Effects:
Documentation:
TBD
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: