Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCL testing to Cmdstan #768

Closed
wants to merge 6 commits into from
Closed

Conversation

rok-cesnovar
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Adds a stage for running cmdstan interface tests with STAN_OPENCL=true which we dont currently run.
This let a small bug get through that was caused by me not pushing all the changes to the repo.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot
Copy link
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 0.99)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 0.99)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 0.96)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 1.02)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 1.0)
(performance.compilation, 1.02)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 0.99)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 0.96)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 0.98)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 1.0)
Result: 0.99628026025
Commit hash: efb72b2

@stan-buildbot
Copy link
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 1.02)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 0.99)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 1.01)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 0.98)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 0.98)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 1.02)
(performance.compilation, 1.02)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 1.0)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 1.03)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 1.11)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 1.01)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 1.0)
Result: 1.01180724259
Commit hash: efb72b2

@rok-cesnovar
Copy link
Member Author

@seantalts @serban-nicusor-toptal Is adding another step ok, or should I join the GPU with the mac interface tests?

@serban-nicusor-toptal
Copy link
Contributor

From my pov creating a new step as it is now it's better then complicate an existing one. Better for tracking errors too.

@stan-buildbot
Copy link
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.02)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 1.0)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 1.06)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 0.98)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 1.01)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 0.98)
(performance.compilation, 1.03)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 1.0)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 1.0)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 1.01)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 0.97)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 1.0)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 0.97)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 1.0)
Result: Regex did not match anything
Commit hash: 6c166a6

@rok-cesnovar
Copy link
Member Author

Closing for now, will reopen once we fix stan-dev/math#1528

@mitzimorris mitzimorris deleted the test-opencl-cmdstan branch February 6, 2020 14:04
yizhang-yiz pushed a commit to metrumresearchgroup/cmdstan that referenced this pull request Apr 19, 2021
cf466ae5d2 Merge branch 'master' into torsten-develop
defd4a9904 fix coupled ode solver signature
c02120b132 Merge pull request stan-dev#778 from nhuurre/lupdf-inlining
2c18a32595 add transformed param test
8188136658 Merge pull request stan-dev#777 from stan-dev/stancjs_no_prints
2b953204c3 cleanup logging in tests
485efc55ea wrapped remaining warning prints in JSON.stringify
b1d953bd51 wrap warning prints in stringify
853f98ffb5 Jenkins node version prefers long lines in the test output for some reason
0ef87308d9 change language
a7d27448eb expand the warnings test
a16b8006ac fix inlining of unnormalized functions
30ba3c7f1a Fix format
1f060f8bf7 Don't include empty strings for no warnings.
dc5de70719 Fix tests and format
b85f4413fe Refactor warnings and try to make no phases print
f019614d66 Refactor warnings-related stuff out into a new Warnings module
f61d726999 Capture Parsing syntax error exceptions.
df595ebfe6 Have deprecation analysis return errors and show how to print them
3c72a3e788 Add js tests from Rok
9df5448124 Merge pull request stan-dev#773 from spinkney/patch-1
6960226eca minor fixes dune runtest & promote
c6eefc7c3c Added stan code
82a27baa91 Merge pull request stan-dev#771 from nhuurre/parser-error-location
e88fefa4f0 Add genearlized inverse
fe35f127a9 move parsing error location
d01ecd3ffb Merge pull request stan-dev#767 from nhuurre/transformed-params-lp
2fb0000fe6 Merge pull request stan-dev#768 from nhuurre/cleanup-indexed-typecheck
8d0142fc44 disallow _lupdf calls in in _lp functions
10991999ca Merge pull request stan-dev#761 from SteveBronder/feature/reader-access-impls
ccfa4cb7b2 simplify indexed expression type inference
d4d99d8efe Merge pull request stan-dev#766 from nhuurre/vector-builder-comma-init
d21cb69a37 allow lp functions in transformed parameters
45e41ef01e avoid copy in FnMakeRowVec
914583e089 update templates
b11d68cdd9 fix spacing
142bf0263a set final for transform_inits
355e7dd0b6 remove final from non-virtual functions
122aebab27 fix formatting
3fbb042710 fix using and update to upstream master
188afd5301 Merge remote-tracking branch 'upstream/master' into feature/reader-access-impls
df9375a553 Merge pull request stan-dev#760 from stan-dev/fix_install_instructions
969756c1d4 adds impl functions for virtual methods which use reader type so that eigen matrices can be passed through
ec9bbd0afc fix install instructions
4c78900a64 Merge pull request stan-dev#726 from adamhaber/add-function-deprectation-warning
2862f02805 added tests
11a4243e02 refactor emit_warnings
6c905789bf renamed functions
16d90cee3b update ode warning, small refactor
dcb6192810 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
f593bcd0e4 merge master
b6150b7cdf removed duplicate logic
4431bc8177 refactor deprecated_userdefined
7f3556aa22 make format
da0f36857e update expected
752914c9a0 emit warning using fold instead of map
bc5e971880 more consistent punctuation
02110ff43d updated expected
2d68bc449f changed warnings to one-liners
4eff2327f9 additional deprecated functions
dac37429f5 removed dup replace_suffix
57ed5afc07 better use of let open String in
0f0d00607f use untyped_statement in mli
c8dfbd4359 removed sexp
87994a49e0 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
abcff23ba2 Updated expected files
57dfd27ecd Merge branch 'cleanup_deprecated_in_distribution_tests' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
649fe3c0fb Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
3ca74030d2 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
db81978577 removed copied comments
0349a8c13d add dep. analysis module

git-subtree-dir: stanc3
git-subtree-split: cf466ae5d210b5604d88dd7cb3947ad44822290a
yizhang-yiz pushed a commit to metrumresearchgroup/cmdstan that referenced this pull request Apr 19, 2021
REVERT: cf466ae5d2 Merge branch 'master' into torsten-develop
REVERT: c02120b132 Merge pull request stan-dev#778 from nhuurre/lupdf-inlining
REVERT: 2c18a32595 add transformed param test
REVERT: 8188136658 Merge pull request stan-dev#777 from stan-dev/stancjs_no_prints
REVERT: 2b953204c3 cleanup logging in tests
REVERT: 485efc55ea wrapped remaining warning prints in JSON.stringify
REVERT: b1d953bd51 wrap warning prints in stringify
REVERT: 853f98ffb5 Jenkins node version prefers long lines in the test output for some reason
REVERT: 0ef87308d9 change language
REVERT: a7d27448eb expand the warnings test
REVERT: a16b8006ac fix inlining of unnormalized functions
REVERT: 30ba3c7f1a Fix format
REVERT: 1f060f8bf7 Don't include empty strings for no warnings.
REVERT: dc5de70719 Fix tests and format
REVERT: b85f4413fe Refactor warnings and try to make no phases print
REVERT: f019614d66 Refactor warnings-related stuff out into a new Warnings module
REVERT: f61d726999 Capture Parsing syntax error exceptions.
REVERT: df595ebfe6 Have deprecation analysis return errors and show how to print them
REVERT: 3c72a3e788 Add js tests from Rok
REVERT: 9df5448124 Merge pull request stan-dev#773 from spinkney/patch-1
REVERT: 6960226eca minor fixes dune runtest & promote
REVERT: c6eefc7c3c Added stan code
REVERT: 82a27baa91 Merge pull request stan-dev#771 from nhuurre/parser-error-location
REVERT: e88fefa4f0 Add genearlized inverse
REVERT: fe35f127a9 move parsing error location
REVERT: d01ecd3ffb Merge pull request stan-dev#767 from nhuurre/transformed-params-lp
REVERT: 2fb0000fe6 Merge pull request stan-dev#768 from nhuurre/cleanup-indexed-typecheck
REVERT: 8d0142fc44 disallow _lupdf calls in in _lp functions
REVERT: 10991999ca Merge pull request stan-dev#761 from SteveBronder/feature/reader-access-impls
REVERT: ccfa4cb7b2 simplify indexed expression type inference
REVERT: d4d99d8efe Merge pull request stan-dev#766 from nhuurre/vector-builder-comma-init
REVERT: d21cb69a37 allow lp functions in transformed parameters
REVERT: 45e41ef01e avoid copy in FnMakeRowVec
REVERT: 914583e089 update templates
REVERT: b11d68cdd9 fix spacing
REVERT: 142bf0263a set final for transform_inits
REVERT: 355e7dd0b6 remove final from non-virtual functions
REVERT: 122aebab27 fix formatting
REVERT: 3fbb042710 fix using and update to upstream master
REVERT: 188afd5301 Merge remote-tracking branch 'upstream/master' into feature/reader-access-impls
REVERT: df9375a553 Merge pull request stan-dev#760 from stan-dev/fix_install_instructions
REVERT: 969756c1d4 adds impl functions for virtual methods which use reader type so that eigen matrices can be passed through
REVERT: ec9bbd0afc fix install instructions
REVERT: 4c78900a64 Merge pull request stan-dev#726 from adamhaber/add-function-deprectation-warning
REVERT: 2862f02805 added tests
REVERT: 11a4243e02 refactor emit_warnings
REVERT: 6c905789bf renamed functions
REVERT: 16d90cee3b update ode warning, small refactor
REVERT: dcb6192810 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
REVERT: f593bcd0e4 merge master
REVERT: b6150b7cdf removed duplicate logic
REVERT: 4431bc8177 refactor deprecated_userdefined
REVERT: 7f3556aa22 make format
REVERT: da0f36857e update expected
REVERT: 752914c9a0 emit warning using fold instead of map
REVERT: bc5e971880 more consistent punctuation
REVERT: 02110ff43d updated expected
REVERT: 2d68bc449f changed warnings to one-liners
REVERT: 4eff2327f9 additional deprecated functions
REVERT: dac37429f5 removed dup replace_suffix
REVERT: 57ed5afc07 better use of let open String in
REVERT: 0f0d00607f use untyped_statement in mli
REVERT: c8dfbd4359 removed sexp
REVERT: 87994a49e0 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
REVERT: abcff23ba2 Updated expected files
REVERT: 57dfd27ecd Merge branch 'cleanup_deprecated_in_distribution_tests' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
REVERT: 649fe3c0fb Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
REVERT: 3ca74030d2 Merge branch 'master' of https://github.com/stan-dev/stanc3 into add-function-deprectation-warning
REVERT: db81978577 removed copied comments
REVERT: 0349a8c13d add dep. analysis module

git-subtree-dir: stanc3
git-subtree-split: defd4a99040c99792ebfb340435b2f8064229cbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants