-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model compile information to stdout and csv #896
Conversation
…4.1 (tags/RELEASE_600/final)
for version
these are the compiler options:
not sure that all of these options will result in there being an output csv file - for the ones that make sense, we need to make sure that this doesn't break any CSV header parsing that exists. |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
is this ready for review? |
Waiting for that PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lcbtm!
Thanks! This has to wait for 2932 in Stan, so this will not go in this release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Addresses a part of #887
Add models compile information (stanc version and flags used) to the stdout and CSV.
Example:
This should be included to make reproducing easier, especially with stanc optimization flag now available.
The tests will fail until stan-dev/stanc3#598 and stan-dev/stan#2932 are merged
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Rok Češnovar, Univ. of Ljubljana
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: