-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tolerance args for (l)bfgs #398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 88.37% 88.48% +0.10%
==========================================
Files 12 12
Lines 2726 2752 +26
==========================================
+ Hits 2409 2435 +26
Misses 317 317
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Thanks. Actually I just realized that |
because only available for lbfgs (not bfgs or newton)
Submission Checklist
Summary
Fixes #388. Adds the remaining (l)bfgs arguments to the optimize method.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: