Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress some compilation messages in non-interactive R sessions #462

Merged
merged 5 commits into from
Mar 10, 2021

Conversation

wlandau
Copy link
Collaborator

@wlandau wlandau commented Mar 10, 2021

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Omit compilation messages "Compiling Stan program..." and "Model executable is up to date!" for non-interactive R sessions. Fixed #429.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):

Eli Lilly and Company

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@wlandau
Copy link
Collaborator Author

wlandau commented Mar 10, 2021

Unit tests tests passed on my local machine in both an interactive and non-interactive session. Looks like there are some issues installing MPI in the GitHub Actions workflows.

@rok-cesnovar
Copy link
Member

@wlandau Thanks! Will take a look shortly. Seems there is an unrelated Ubuntu package installation issue, will restart tests until it goes away :)

Err:9 http://azure.archive.ubuntu.com/ubuntu focal-updates/main amd64 libxnvctrl0 amd64 440.82-0ubuntu0.20.04.1
  404  Not Found [IP: 52.252.75.106 80]

@rok-cesnovar
Copy link
Member

@wlandau please merge master in whenever you have the chance. The CI fix was pushed there.

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @wlandau!

@rok-cesnovar rok-cesnovar merged commit 3bf1a2b into stan-dev:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress the remaining messages in cmdstan_model() if quiet is TRUE?
3 participants