Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Linux ARM tarball automatically #531

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Install Linux ARM tarball automatically #531

merged 2 commits into from
Jul 20, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary

Fixes #503

I didnt find a way to add a test as we dont have ARM machines to test this with so existing install tests on x86 will have to suffice. I did try it on an AWS ARM machine and it works.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #531 (d96c63a) into master (19056cf) will decrease coverage by 1.17%.
The diff coverage is 88.88%.

❗ Current head d96c63a differs from pull request most recent head 849915f. Consider uploading reports for the commit 849915f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   92.79%   91.61%   -1.18%     
==========================================
  Files          12       12              
  Lines        3041     3007      -34     
==========================================
- Hits         2822     2755      -67     
- Misses        219      252      +33     
Impacted Files Coverage Δ
R/install.R 63.27% <88.88%> (-5.29%) ⬇️
R/run.R 94.07% <0.00%> (-1.65%) ⬇️
R/utils.R 90.71% <0.00%> (-1.43%) ⬇️
R/model.R 90.93% <0.00%> (-0.81%) ⬇️
R/csv.R 98.21% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19056cf...849915f. Read the comment docs.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me!

@rok-cesnovar rok-cesnovar merged commit b317b42 into master Jul 20, 2021
@rok-cesnovar rok-cesnovar deleted the install_arm branch July 20, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Linux ARM systems download the ARM Linux CmdStan
3 participants