-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vignette on how to handle deprecations with $format() #644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 12 12
Lines 3406 3406
=======================================
Hits 3155 3155
Misses 251 251 Continue to review full report at Codecov.
|
Is there a bug in the format method? I don't think it's actually overwriting the Stan file when mod$format(
canonicalize = list("deprecations"),
overwrite_file = TRUE,
backup = FALSE
)
mod$print() Then |
I think print() might use a stored string of the file? |
Yeah. I think we need to put the string of the new Stan code in |
Ok I think I fixed the printing issue. If that fix and my edits to the vignette look good to you then I think this is ready. |
Actually I think we also still need to do this part of #626:
|
Submission Checklist
Summary
Adds a vignette on handling deprecations with the canonicalizer available through the
$format()
method.Online vignette can be seen here: https://rok-cesnovar.github.io/cmdstanr/articles/deprecations.html
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: