Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbosity to download output and errors #745

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

This PR updates the file downloading functions to respect the quiet argument from an install_cmdstan() call, and also to print the actual error message if the download fails.

This will hopefully help with debugging issues like #731

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Merging #745 (baadb05) into master (b96a62a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head baadb05 differs from pull request most recent head 2a6d2c9. Consider uploading reports for the commit 2a6d2c9 to get more accurate results

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   88.30%   88.36%   +0.06%     
==========================================
  Files          12       12              
  Lines        4077     4082       +5     
==========================================
+ Hits         3600     3607       +7     
+ Misses        477      475       -2     
Impacted Files Coverage Δ
R/install.R 62.89% <100.00%> (+0.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea!

@andrjohns andrjohns merged commit 4c4dd09 into master Mar 23, 2023
@andrjohns andrjohns deleted the verbose-download branch March 23, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants