Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtools43 support #755

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Rtools43 support #755

merged 3 commits into from
Apr 5, 2023

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

There was a report on the forum that cmdstanr's toolchain checks weren't working with RTools43, this PR updates the functions to correctly detect the RTools42 vs RTools43

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Assuming tests pass on the rtools43 GHA instance, feel free to merge. Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #755 (1fdd923) into master (a30d3e9) will decrease coverage by 2.30%.
The diff coverage is 26.66%.

❗ Current head 1fdd923 differs from pull request most recent head 94f6395. Consider uploading reports for the commit 94f6395 to get more accurate results

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   88.36%   86.07%   -2.30%     
==========================================
  Files          12       12              
  Lines        4099     4107       +8     
==========================================
- Hits         3622     3535      -87     
- Misses        477      572      +95     
Impacted Files Coverage Δ
R/install.R 49.22% <15.38%> (-13.68%) ⬇️
R/utils.R 72.64% <100.00%> (-1.87%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrjohns andrjohns merged commit e396878 into master Apr 5, 2023
@rok-cesnovar rok-cesnovar deleted the rtools43-support branch June 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants