Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store return codes instead of always querying exit status #798

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jul 27, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes #780 by saving the return codes when the fit object is initialized. @rok-cesnovar This was the most obvious solution to me, but maybe there's a better way to do this?

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the most obvious solution to me, but maybe there's a better way to do this?

I think this is completely fine.

@codecov-commenter
Copy link

Codecov Report

Merging #798 (89b4b4f) into master (5b3426f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 89b4b4f differs from pull request most recent head b5a33bf. Consider uploading reports for the commit b5a33bf to get more accurate results

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          12       12           
  Lines        4152     4152           
=======================================
  Hits         3665     3665           
  Misses        487      487           
Files Changed Coverage Δ
R/fit.R 96.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgabry jgabry merged commit 8505e5b into master Jul 27, 2023
@jgabry jgabry deleted the store-return-codes branch July 27, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_object() for variational fit loses return code
3 participants