-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes in .stanfunctions, hessian model method, and exposing RNG functions #811
Conversation
Good idea, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 88.24% 86.58% -1.67%
==========================================
Files 12 12
Lines 4161 4175 +14
==========================================
- Hits 3672 3615 -57
- Misses 489 560 +71
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andrew is on a roll, I love it :)
Thanks @andrjohns! |
Submission Checklist
Summary
This PR comprises two small bugfixes:
.stanfunctions
was not treated as a valid extensionmath/mix.hpp
was not included early enough, resulting in compilation errors for somehessian
modelsAnd one slightly larger bugfix in the handling of exposing RNG functions. Currently, we expose RNG functions with an integer
seed
argument (default = 0) - such that users need to change thisseed
argument if they want a different value on each call. This PR changes that behaviour to initialise a Boost RNG and store it in the functions environment, which is then passed to the exposed RNG function - allowing the exposed RNG function to act as expected.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: