-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility fixes for cmdstan 2.33+ #843
Conversation
I think there’s something else in the deprecations vignette that’s causing an error but I don’t have time to check right now. Will come back to this later tonight or in the next few days. |
@rok-cesnovar @andrjohns Actually the Deprecations vignette is now just wrong because it's all about deprecation warnings but all the warnings it shows are now errors as of 2.33. So we need to decide what to do about that vignette. Do we want to rewrite it to be about fixing errors instead of warnings? Something else? Until we figure that out every cmdstanr PR will error during unit tests because this vignette won't run with 2.33 |
I pushed one commit yesterday that I thought would fix it (changing array syntax) but turns out all the other warnings are errors now too. So not sure what we want to do about that. |
I would remove it and make an issue to make a short vignette on how to use the auto-formatter to convert these models. |
That sounds good to me |
This is still failing after removing the vignette, apparently because 2.33 broke a few things in cmdstanr. E.g., |
I'm going to merge #847 into this PR/branch since the vignette deprecations are also causing the tests in that PR to fail. Then we can make this PR a general 2.33-fixes PR if anything else pops up |
Sounds good, thanks @andrjohns! |
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 88.38% 86.41% -1.97%
==========================================
Files 12 12
Lines 4201 4212 +11
==========================================
- Hits 3713 3640 -73
- Misses 488 572 +84
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jgabry @rok-cesnovar this is passing and ready to have a look at. The only change that I'm not sure about is that reading estimates after a failed No idea why, or how important it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I dont know about the optimize(), will investigate whether this was a change in cmdstan, but I think we can merge the PR before that.
Looks good to me too, thanks! |
Submission Checklist
Summary
Fixes old array syntax in some examples.
I've been teaching a Stan workshop and noticed when showing the cmdstanr doc that we still use the old array syntax in a few places.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: