Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for installing from release archive #866

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Closes #865 by adding the option to install cmdstan from a downloaded release archive:

install_cmdstan(release_file = "./cmdstan-2.33.1.tar.gz")

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

Codecov Report

Merging #866 (73157b4) into master (ede72e3) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

❗ Current head 73157b4 differs from pull request most recent head 94508ef. Consider uploading reports for the commit 94508ef to get more accurate results

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   88.32%   88.30%   -0.03%     
==========================================
  Files          12       12              
  Lines        4370     4377       +7     
==========================================
+ Hits         3860     3865       +5     
- Misses        510      512       +2     
Files Coverage Δ
R/install.R 63.14% <88.88%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgabry jgabry merged commit 5bd7ef3 into master Oct 17, 2023
12 checks passed
@jgabry jgabry deleted the install-release-file branch October 17, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install_cmdstan() fails because it can't be downloaded
3 participants