Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ebfmi threshold with cmdstan #892

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Align ebfmi threshold with cmdstan #892

merged 1 commit into from
Jan 11, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

The cmdstanr diagnostic threshold for low E-BFMI is 0.2, while the cmdstan threshold is 0.3

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48a2b3e) 88.36% compared to head (6b40704) 88.36%.

❗ Current head 6b40704 differs from pull request most recent head 29a4682. Consider uploading reports for the commit 29a4682 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files          12       12           
  Lines        4528     4528           
=======================================
  Hits         4001     4001           
  Misses        527      527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrjohns
Copy link
Collaborator Author

Going to merge this since it's minor and should be considered a bugfix

@andrjohns andrjohns merged commit 5ae46d3 into master Jan 11, 2024
12 checks passed
@andrjohns andrjohns deleted the ebfmi-threshold branch January 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants