Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop RcppEigen dependency, implement basic Eigen -> C++ interop #899

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

We currently have RcppEigen as a suggests for use with the model methods and function exports. However, given that we already have the Eigen headers in the cmdstan install, we only need the methods for converting between R and C++ Eigen types.

Since only a reduced subset of Eigen types are exposed via Stan (Eigen::Matrix<>), this is fairly simple to to handle ourselves.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d444e7f) 88.37% compared to head (6f775f9) 88.37%.

❗ Current head 6f775f9 differs from pull request most recent head b33dd02. Consider uploading reports for the commit b33dd02 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   88.37%   88.37%   -0.01%     
==========================================
  Files          12       12              
  Lines        4535     4532       -3     
==========================================
- Hits         4008     4005       -3     
  Misses        527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Always nice to drop another dependency. If this is fully ready go ahead and merge.

@andrjohns andrjohns merged commit 2355447 into master Jan 18, 2024
12 checks passed
@andrjohns andrjohns deleted the drop-rcppeigen-dep branch January 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants