move sd.complex into sd.default because sd.matrix overrides sd.complex

stan-dev · Nov 24, 2023 · 31f82f8 · 31f82f8
1 parent 3bab85c
commit 31f82f8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -276,7 +276,6 @@ S3method(rhat_basic,default)
 S3method(rhat_basic,rvar)
 S3method(rhat_nested,default)
 S3method(rhat_nested,rvar)
-S3method(sd,complex)
 S3method(sd,default)
 S3method(sd,rvar)
 S3method(split_chains,draws)

diff --git a/R/rvar-summaries-over-draws.R b/R/rvar-summaries-over-draws.R
@@ -206,11 +206,14 @@ var.rvar <- variance.rvar
 sd <- function(x, ...) UseMethod("sd")
 #' @rdname rvar-summaries-over-draws
 #' @export
-sd.default <- function(x, ...) stats::sd(x, ...)
-#' @rdname rvar-summaries-over-draws
-#' @export
-sd.complex <- function(x, ...) {
-  sqrt(variance(c(x), ...))
+sd.default <- function(x, ...) {
+  # because complex matrices do not dispatch on the complex class, check for
+  # complex numbers here
+  if (is.complex(x)) {
+    sqrt(variance(c(x), ...))
+  } else {
+    stats::sd(x, ...)
+  }
 }
 #' @rdname rvar-summaries-over-draws
 #' @export

diff --git a/man/rvar-summaries-over-draws.Rd b/man/rvar-summaries-over-draws.Rd