-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vignette prior predictive #465
base: master
Are you sure you want to change the base?
Conversation
Thanks for reminding me! Somehow this wasn't on my to-do list anymore but should have been. I'll try to spend a bit of time on it ASAP. I think we should include it in the next rstanarm release. |
Is it ok if I make edits/additions directly or do you prefer that I just make comments? |
Nah go ahead and make edits, also add yourself as a co-author! :)
Lauren
…On Thu, Aug 27, 2020, 5:26 AM Jonah Gabry ***@***.***> wrote:
Is it ok if I make edits/additions directly or do you prefer that I just
make comments?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#465 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZMGFGS7HSGONFGOAIEZLSCVOU5ANCNFSM4QLJWVTA>
.
|
@lauken13 I should have already done this after we merged the MRP vignette but looks like I forgot, sorry!
Ok cool will do! |
@lauken13 I made a bunch of edits to the first half (it looks like I changed more than I actually did because some changes are just reflowing lines). I'll go through the second half (the part about priors for the slope) soon. A few general things that I noticed:
|
Yeah I think that sounds like a good idea. Do you have any suggestions for
other examples? Normal linear regression?
I'd be fine to redo the data manipulation with base R, if that makes more
sense for the package!
…On Thu, Aug 27, 2020 at 10:12 AM Jonah Gabry ***@***.***> wrote:
@lauken13 <https://github.com/lauken13> I made a bunch of edits to the
first half (it looks like I changed more than I actually did because some
changes are just reflowing lines). I'll go through the second half (the
part about priors for the slope) soon.
A few general things that I noticed:
-
Because rstanarm doesn't list dplyr or tidyr in the DESCRIPTION file
we'll need to either not use dplyr and tidyr or do something similar to the
MRP vignette where we pre-processed anything that needed those packages.
Alternatively we can add them to the Suggests field in the DESCRIPTION
file if @bgoodri <https://github.com/bgoodri> is OK with it.
-
We might want to consider adding another example that isn't logistic
regression. It occurred to me that logistic regression is actually a
special case where it makes more sense to look at the latent Pr(y = 1)
instead of actual values of y simulated from the bernoulli using Pr(y = 1).
Because we don't actually simulate outcomes this example technically
doesn't use the prior predictive distribution, which could be confusing. I
tried to mention this in some of my edits, but it's still a bit weird not
to have an actual example of drawing from the predictive distribution. What
do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#465 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZMGC2SYYNW6OCN4PLBU3SCWQFHANCNFSM4QLJWVTA>
.
|
Yeah I think linear regression would good. I don't think we need anything too complicated, just something to illustrate using
If that's not too much of a pain that would be great! |
Hi Jonah,
Just wanted to follow up with this vignette, is it still useful?