Remove unnecessary forward decls from MIR, code-gen appropriately #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
changed the title
nhuurre
requested changes
Mar 23, 2023
|
Huh, I pushed but my commits haven't shown up here. Odd |
nhuurre
reviewed
Mar 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 89.02% 89.08% +0.05%
==========================================
Files 64 64
Lines 9752 9754 +2
==========================================
+ Hits 8682 8689 +7
+ Misses 1070 1065 -5
|
nhuurre
approved these changes
Mar 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Closes #1297 and fixes an issue where external functions could not be used in higher-order functions without the end-user supplying an implementation of our functor structs.
This uses code we already had since #1277 to remove "unnecessary" forward decls when we go from AST to MIR. This means all remaining forward decls in the MIR must be for external functions, so we can treat them as such later on.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)