Move runtime.initBindings() call into runtime.addDefaultValue().

standard-things · Nov 15, 2018 · 6feb50b · 6feb50b
1 parent 6976dd6
commit 6feb50b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/runtime.js b/src/runtime.js
@@ -37,6 +37,10 @@ const {
 const Runtime = {
   addDefaultValue(value) {
     this.addExportGetters([["default", () => value]])
+
+    if (value === void 0) {
+      this.initBindings(["default"])
+    }
   },
 
   addExportFromSetter(importedName, exportedName = importedName) {

diff --git a/src/visitor/import-export.js b/src/visitor/import-export.js
@@ -279,7 +279,8 @@ function init() {
           // If the exported expression is a comma-separated sequence expression
           // it may not include the vital parentheses, so we should wrap the
           // expression with parentheses to make sure it's treated as a single
-          // argument to `runtime.default()`, rather than as multiple arguments.
+          // argument to `runtime.addDefaultValue()`, rather than as multiple
+          // arguments.
           prefix += "("
           suffix = ")" + suffix
         }
@@ -300,11 +301,6 @@ function init() {
 
       if (isInitable(declaration)) {
         this.initedBindings.default = true
-
-        magicString.appendRight(
-          declaration.end,
-          runtimeName + '.j(["default"]);'
-        )
       }
 
       path.call(this, "visitWithoutReset", "declaration")

diff --git a/test/output/default-expression/expected.mjs b/test/output/default-expression/expected.mjs
@@ -2,4 +2,4 @@
 
 // This default expression will evaluate to 0 if the parentheses are
 // mistakenly stripped away.
-_.d((value++, value));_.j(["default"]);
+_.d((value++, value));