Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci workflow versions #639

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

mjankowski
Copy link
Contributor

Should resolve the two node version warnings in output of update task - https://github.com/standardrb/standard/actions/runs/9736076397

There are other deprecations there re: the set-output command, and a failure in latest run. May check those out separately.

@searls searls merged commit 89c13ed into standardrb:main Jul 2, 2024
4 checks passed
@mjankowski
Copy link
Contributor Author

The failure on the workflow run might be perms related? - https://github.com/standardrb/standard/actions/runs/9736076397/job/26866177750#step:10:217

remote: Permission to standardrb/standard.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/standardrb/standard/': The requested URL returned error: 403
Error: The process '/usr/bin/git' failed with exit code 128

@searls
Copy link
Contributor

searls commented Jul 2, 2024

Maybe this is an older way of doing stuff? I haven't looked at that workflow before, but recently I've been seeing explicit repo-level permissions like this (in Standard's own official action):

jobs:
  build:
    runs-on: ubuntu-latest
    permissions:
      checks: write
      contents: write
    steps:
    - name: Standard Ruby
      uses: standardrb/standard-ruby-action@v1

@mjankowski
Copy link
Contributor Author

I have also not looked at that workflow in detail and am half-guessing here.

The logs and records only go back so far - https://github.com/standardrb/standard/actions/workflows/update.yml - but its been failing for a while.

Does the github-actions user have the correct perms at the org/repo level? https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#workflow-permissions

@mjankowski mjankowski deleted the update-ci-workflow branch November 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants