Fix --exit-on-error not working and add --skip-completed-runs #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teetone
requested changes
Mar 2, 2023
src/helm/benchmark/runner.py
Outdated
| @@ -106,6 +117,12 @@ def run_one(self, run_spec: RunSpec): | |||
| run_path: str = os.path.join(self.runs_path, run_spec.name) | |||
| ensure_directory_exists(run_path) | |||
|
|
|||
| if os.path.exists(os.path.join(run_path, "scenario_state.json")): | |||
There was a problem hiding this comment.
I don't see where skip_completed_runs is being used. Should we check it here?
There was a problem hiding this comment.
Thanks for catching the bug. Added the flag check.
|
@teetone could you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--exit-on-errorwas broken by Merge present.py into run.py #1302--skip-completed-runsis useful for re-runninghelm-runon the samerun_specs.confif some runs fail, without having to create a newrun_specs.confwith only the failing runs.