Fix corner cases in LocalWindowService truncation and In-context Adapter #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
requested changes
Apr 3, 2023
| @@ -222,7 +222,7 @@ def construct_example_prompt(self, instance: Instance, include_output: bool, ref | |||
| Returns a single example of the prompt. `include_output` controls whether the gold output is included. | |||
| """ | |||
| # Input | |||
| result: str = self.adapter_spec.input_prefix + instance.input.text + self.adapter_spec.input_suffix | |||
| result: str = self.adapter_spec.input_prefix + str(instance.input.text) + self.adapter_spec.input_suffix | |||
There was a problem hiding this comment.
str(None) is 'None', which is probably not what you want. If you want the empty string in the case of None, you could use (instance.input.text or "") instead.
| # in https://github.com/stanford-crfm/helm/issues/1448). | ||
| # Truncate by removing character by character until the prompt fits within the context window. | ||
| while not self.fits_within_context_window(result, expected_completion_token_length): | ||
| result = result[:-1] |
There was a problem hiding this comment.
Naively truncating characters from the right until it fits the context window sounds reasonable to me.
cc @teetone @percyliang FYI for the change in window service behavior.
There was a problem hiding this comment.
I think truncation in the middle may also work (This avoid truncating "Answer: "). Another approach is to use LLM itself to extract a shorter summary of the context.
There was a problem hiding this comment.
I revised it this way to align with the other window services.
yifanmai
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance.input.textcan beNone, and may trigger str + None error. We simply wrapped it withstr()