Handle retry attempts better: print exception and stack trace #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
reviewed
May 12, 2023
|
I've made the changes, thanks @yifanmai for sharing the way to print the rror. Works fine now. |
yifanmai
requested changes
May 13, 2023
| # The lock is used to prevent multiple threads from printing at the same time. | ||
| # This can cause issues when printing the stack trace. | ||
| # (The stack traces can get mixed up and become unreadable.) | ||
| print_lock: threading.Lock = threading.Lock() |
There was a problem hiding this comment.
This is okay, but note: the stack trace logging may still be interleaved with other logging, and this is expected behavior.
There was a problem hiding this comment.
Yeah I know, it's just so that there a not 2 stacks traces at the same time
yifanmai
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #1471
I tried also to handle KeyboardInterrupt but is is not super consistent.