Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily import client modules in AutoClient #1679

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Lazily import client modules in AutoClient #1679

merged 1 commit into from
Jun 21, 2023

Conversation

yifanmai
Copy link
Collaborator

  • Allows clients to use optional dependencies.
  • Significantly speeds up AutoClient import time from several seconds to <100ms.
  • Significantly speeds up helm-run initialization time, which was dominated by AutoClient import time.

Addresses #1327

@yifanmai yifanmai requested review from percyliang and teetone June 21, 2023 00:03
percyliang
percyliang approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yifanmai yifanmai merged commit 2bb4d78 into main Jun 21, 2023
@yifanmai yifanmai deleted the yifanmai/1327-auto-client branch June 21, 2023 20:18
@yifanmai yifanmai mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@percyliang percyliang percyliang approved these changes

@teetone teetone Awaiting requested review from teetone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yifanmai @percyliang