Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPT-4 Turbo (preview) #2092

Merged
merged 2 commits into from
Dec 6, 2023
Merged

GPT-4 Turbo (preview) #2092

merged 2 commits into from
Dec 6, 2023

Conversation

teetone
Copy link
Member

@teetone teetone commented Dec 5, 2023

Tested with MedQA and NarrativeQA with just 10 instances. It seems to generate reasonable completions.

Information about the model: https://help.openai.com/en/articles/8555510-gpt-4-turbo

@JosselinSomervilleRoberts
Copy link
Contributor

@teetone the test that is failing is in test_model_properties. This test was used for the refactorization and I think we should remove it. I will send a PR for this. In the meantime, you can simply add the corresponding ModelDeployment to the test and everything will pass.

Copy link
Contributor

@JosselinSomervilleRoberts JosselinSomervilleRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you fix the test

@teetone
Copy link
Member Author

teetone commented Dec 6, 2023

@teetone the test that is failing is in test_model_properties. This test was used for the refactorization and I think we should remove it. I will send a PR for this. In the meantime, you can simply add the corresponding ModelDeployment to the test and everything will pass.

@JosselinSomervilleRoberts Actually, your test is good. It made me realize that I should add a separate window service for the 128K context length :)

@teetone teetone merged commit e3421a3 into main Dec 6, 2023
6 checks passed
@teetone teetone deleted the gpt4-turbo branch December 6, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants