-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update landing page with leaderboard #2113
Conversation
…rfm/helm into farzaan/new-front-end
ignoreHref={true} | ||
filtered | ||
filteredModels={[ | ||
"Llama 2 (70B)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard-coding isn't going to work in general - is there a way to dynamically compute the top ones from the real leaderboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can do that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a GitHub issue given that this wasn't handled in this PR? We're going to have a different list of models, so this needs to get fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will make 2 issues, 1 for making the filtered models dynamic, and the second for the style stuff. I'll get those in tonight after a final I have (4-7pm), with the first one as the main priority.
|
||
export default async function getSchema(signal: AbortSignal): Promise<Schema> { | ||
try { | ||
const resp = await fetch(getSchemaJsonUrl(), { signal }); | ||
const resp = await fetch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we changing this back from what was in main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a relic of my forked codebase not being rebased with your changes. I'll fix it by reverting to your changes.
Preview at my forked repo https://farzaank.github.io/helm/