Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update landing page with leaderboard #2113

Merged
merged 44 commits into from
Dec 8, 2023
Merged

Update landing page with leaderboard #2113

merged 44 commits into from
Dec 8, 2023

Conversation

farzaank
Copy link
Contributor

@farzaank farzaank commented Dec 7, 2023

  • Adds mini leaderboard
  • Moves GH link to nav bar
  • Makes Navbar sticky
  • Updates schema loading to be compatible with both release types
  • Adds search bar for raw runs' metric pages

Preview at my forked repo https://farzaank.github.io/helm/

@farzaank farzaank changed the title Update landing page Update landing page with leaderboard Dec 8, 2023
ignoreHref={true}
filtered
filteredModels={[
"Llama 2 (70B)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hard-coding isn't going to work in general - is there a way to dynamically compute the top ones from the real leaderboard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I can do that here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a GitHub issue given that this wasn't handled in this PR? We're going to have a different list of models, so this needs to get fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will make 2 issues, 1 for making the filtered models dynamic, and the second for the style stuff. I'll get those in tonight after a final I have (4-7pm), with the first one as the main priority.


export default async function getSchema(signal: AbortSignal): Promise<Schema> {
try {
const resp = await fetch(getSchemaJsonUrl(), { signal });
const resp = await fetch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this back from what was in main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a relic of my forked codebase not being rebased with your changes. I'll fix it by reverting to your changes.

@yifanmai yifanmai merged commit 7b4935d into main Dec 8, 2023
3 checks passed
@yifanmai yifanmai deleted the farzaan/new-front-end branch December 8, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants