Add Gemini #2186
Merged
Add Gemini #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be good to go. The quota increase to 600 requests per minute has been submitted. I updated the metadata and parameters which I think are correct now. |
teetone
approved these changes
Dec 22, 2023
| # TODO: support VLM such as "gemini-pro-vision" | ||
| model_name: str = "" | ||
| if request.model_engine == "gemini": | ||
| model_name = "gemini-pro" |
There was a problem hiding this comment.
How does model versioning work? I believe sending a request with gemini-pro will just get the latest version.
There was a problem hiding this comment.
We will revisit later when Google releases more versions.
|
I think it's simpler to just match their name and call it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs more testing but so far works on MMLU.