Provide basic image support #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
approved these changes
Feb 16, 2024
| ) : null} | ||
| </div> | ||
| </div> | ||
| <div className="accordion-wrapper"> |
There was a problem hiding this comment.
Everything to do with the prompt should be unified with the text predictions case - only the prediction text / image part has to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides basic image support such that HEIM can use the new front-end. Existing HELM frontends should be unchanged as a result of this.
There could be a better logic switch/thing to check before triggering the image display versus the normal text display. We can discuss that here.
Try it here
Compare it to the existing frontend
I will follow-up with some other changes that makes HEIM work generally.