Minor unitxt fixes #2553
Merged
Minor unitxt fixes #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farzaank
approved these changes
Apr 4, 2024
elronbandel
reviewed
Apr 4, 2024
| @@ -15,7 +15,7 @@ def get_unitxt_spec(**kwargs) -> RunSpec: | |||
| name_suffix = ",".join([f"{key}={value}" for key, value in kwargs.items()]) | |||
| name = f"unitxt:{name_suffix}" | |||
| scenario_spec = ScenarioSpec(class_name="helm.benchmark.scenarios.unitxt_scenario.UnitxtScenario", args=kwargs) | |||
| adapter_spec = get_generation_adapter_spec() | |||
| adapter_spec = get_generation_adapter_spec(max_train_instances=0) | |||
There was a problem hiding this comment.
Can we set this things here as well @yifanmai ?
method: str = ""
global_prefix: str = ""
instructions: str = ""
input_prefix: str = ""
input_suffix: str = ""
reference_prefix: str = "A. "
reference_suffix: str = ""
output_prefix: str = ""
output_suffix: str = ""
instance_prefix: str = ""
elronbandel
suggested changes
Apr 4, 2024
|
@elronbandel thanks for the advice. I fixed the Also note that you might still see weird prefixes and suffixed if you use certain Google / OpenAI / Mistral models, this will be fixed by #2550. |
|
Thanks @yifanmai ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_train_instancesto 0 because unitxt handles training instance selectionAdapterSpecfor unitxtrun_entries_unitxt.conf.gitignoreto only ignore configuration files at root