Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama 3 #2579

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add Llama 3 #2579

merged 3 commits into from
Apr 18, 2024

Conversation

yifanmai
Copy link
Collaborator

No description provided.

@yifanmai yifanmai requested review from percyliang and farzaank April 18, 2024 19:13
@@ -1184,6 +1184,23 @@ models:
# TODO(#1828): Upgrade to FULL_FUNCTIONALITY_TEXT_MODEL_TAG
tags: [TEXT_MODEL_TAG, LIMITED_FUNCTIONALITY_TEXT_MODEL_TAG]

- name: meta/llama-3-8b
display_name: Llama 3 (8B)
description: TBD # TODO: Fill in description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For speed of getting this up, do we want to merge without this TODO done?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the description.

@yifanmai yifanmai merged commit 6fec487 into main Apr 18, 2024
6 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-add-llama-3 branch April 18, 2024 23:41
@mtake
Copy link
Collaborator

mtake commented Apr 19, 2024

@yifanmai
Copy link
Collaborator Author

yifanmai commented Apr 19, 2024

@mtake Yes, it is swapped. Thanks for catching this!

Fixing in #2581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants