VHELM improvements #2825
Merged
VHELM improvements #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
requested changes
Jul 29, 2024
|
|
||
| # Save the image to disk | ||
| image = row["image"] | ||
| image_file_name: str = generate_hash(image) + ".jpg" |
There was a problem hiding this comment.
Why not just name this f"{split}_{row_index}.jpg"? Then we won't need hashes.
There was a problem hiding this comment.
I want a unique hash per image because I worried the underlying huggingface dataset could get reshuffled.
There was a problem hiding this comment.
You can deal with this by passing the githash e.g. revision="e9488045cbad16c973f031c7a8f7466b5dcc3794" to load_dataset(), then you don't have to worry about mutations. We should probably do this for all other usages of load_dataset(), also.
yifanmai
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
VISION_LANGUAGE_MODEL_TAGtag toopenai/gpt-4-turbo-2024-04-09