Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] #275

Closed
Faiqonli opened this issue Jan 2, 2025 · 0 comments
Closed

[BUG] #275

Faiqonli opened this issue Jan 2, 2025 · 0 comments

Comments

@Faiqonli
Copy link

Faiqonli commented Jan 2, 2025

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Report following things

  1. Input topic name
  2. All output files generated for this topic as a zip file.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  • OS: [e.g. iOS, Windows]
  • Browser [e.g. chrome, safari] if the bug report is UI problem
Faiqonli added a commit to Faiqonli/storm that referenced this issue Jan 3, 2025
@Faiqonli
Fix bug causing incorrect output files for a given input topic name
c0ab617 
Fixes stanford-oval#275

Add validation for output files in `run_costorm_gpt.py`.

* Add `validate_output_files` function to check for the existence and non-emptiness of expected output files.
* Call `validate_output_files` after generating output files to ensure correctness.
* Update `main` function to include validation of output files based on the input topic name.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stanford-oval/storm/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
@Faiqonli Faiqonli mentioned this issue Jan 3, 2025
Closed
Faiqonli added a commit to Faiqonli/storm that referenced this issue Jan 4, 2025
@Faiqonli
Fix bug causing incorrect output files for a given input topic name
c2dc793 
Related to stanford-oval#275

Add validation for output files in `run_costorm_gpt.py`.

* Add `validate_output_files` function to check for the existence and non-emptiness of expected output files.
* Call `validate_output_files` after generating output files to ensure correctness.
* Update `main` function to include validation of output files based on the input topic name.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stanford-oval/storm/issues/275?shareId=XXXX-XXXX-XXXX-XXXX).
@Faiqonli Faiqonli mentioned this issue Jan 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug causing incorrect output files for a given input topic name Faiqonli/storm
2 participants
@shaoyijia @Faiqonli